Skip to content

Introduce Direction enum for OrderField + Introduce Conjunction enum for WhereGroup #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Introduce Direction enum for OrderField + Introduce Conjunction enum for WhereGroup #23

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
692ab4a
add types to constants
pavog Aug 6, 2025
81bc09a
add enum for direction of order
pavog Aug 7, 2025
044100b
add enum for conjunction of WhereGroup
pavog Aug 7, 2025
07a0d0f
check for is_string instead of !is_int
pavog Aug 7, 2025
a9d901d
throw InvalidArgumentException if value in orderBy is not OrderField …
pavog Aug 7, 2025
e3ad1b1
use $value as direction it $value is instance of Direction
pavog Aug 7, 2025
561b59f
fix: use Direction::ASCENDING instead of OrderField::ASCENDING
pavog Aug 7, 2025
d131c83
use else if
pavog Aug 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Driver/Cassandra/Cassandra.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
*/
class Cassandra extends Driver implements CRUDAbleInterface, QueryableInterface
{
public const ID = "cassandra";
public const string ID = "cassandra";
protected string $id = self::ID;

/**
Expand Down
2 changes: 1 addition & 1 deletion src/Driver/Mysqli/Mysqli.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
*/
class Mysqli extends Driver implements CRUDAbleInterface, CRUDQueryableInterface
{
public const ID = "mysqli";
public const string ID = "mysqli";
protected string $id = self::ID;

/**
Expand Down
2 changes: 1 addition & 1 deletion src/Driver/OpenSearch/OpenSearch.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
*/
class OpenSearch extends Driver implements CRUDAbleInterface, SearchableInterface
{
public const ID = "opensearch";
public const string ID = "opensearch";
protected string $id = self::ID;

/**
Expand Down
2 changes: 1 addition & 1 deletion src/Driver/Redis/Redis.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
*/
class Redis extends Driver implements CRUDAbleInterface, CacheableInterface
{
public const ID = "redis";
public const string ID = "redis";
protected string $id = self::ID;

/**
Expand Down
2 changes: 1 addition & 1 deletion src/Driver/Test/TestDriver.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

class TestDriver extends Driver implements CRUDAbleInterface, CRUDQueryableInterface
{
public const ID = "test";
public const string ID = "test";
protected string $id = self::ID;

/**
Expand Down
2 changes: 1 addition & 1 deletion src/Query/CountField.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
*/
class CountField extends SelectField
{
public const COUNT_FIELD = "count";
public const string COUNT_FIELD = "count";

public ?int $function = self::COUNT;
public ?string $alias = self::COUNT_FIELD;
Expand Down
4 changes: 2 additions & 2 deletions src/Query/OrderField.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ class OrderField
/**
* Direction constants
*/
const ASCENDING = 0;
const DESCENDING = 1;
const int ASCENDING = 0;
const int DESCENDING = 1;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this would be better as an enum. The value doesn't actually mean anything useful.


/**
* Field name to order by
Expand Down
4 changes: 2 additions & 2 deletions src/Query/WhereGroup.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@ class WhereGroup implements Iterator, Countable
/**
* Conjunction values
*/
const AND = 0;
const OR = 1;
const int AND = 0;
const int OR = 1;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this would be better as an enum. The value doesn't actually mean anything useful.


/**
* Multiple WhereGroup or WhereCondition objects
Expand Down
Loading