In-source @parcel/source-map and the native code into Atlaspack #789
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 566bde7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 115 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
🦀 Ferris' Rust Changeset CheckI can see you have now included |
marcins
commented
Sep 12, 2025
marcins
commented
Sep 12, 2025
Contributor
Author
There was a problem hiding this comment.
This file is currently a copy of https://github.com/parcel-bundler/source-map/blob/master/parcel_sourcemap_node/src/lib.rs
marcins
commented
Sep 12, 2025
Contributor
Author
There was a problem hiding this comment.
This whole folder is a copy of https://github.com/parcel-bundler/source-map/tree/master/parcel_sourcemap
Merging this into the existing atlaspack_sourcemap would be a next step, as that crate is (mostly) a wrapper around this one.
Contributor
Author
There was a problem hiding this comment.
The files in here are mostly copied from https://github.com/parcel-bundler/source-map/tree/master/src, with a conversion to TS and other minor changes to make things work with TS.
marcins
force-pushed
the
mszczepanski/insource-source-map
branch
from
d7904d4 to
17c0457
Compare
marcins
force-pushed
the
mszczepanski/insource-source-map
branch
from
17c0457 to
51ecd1d
Compare
Contributor
📊 Type Coverage ReportCoverage Comparison
Files with Most Type Issues (Top 15)
This report was generated by the Type Coverage GitHub Action |
marcins
commented
Sep 25, 2025
mattcompiles
approved these changes
Sep 29, 2025
JakeLane
approved these changes
Sep 29, 2025
marcins
force-pushed
the
mszczepanski/insource-source-map
branch
from
5779cd2 to
932473e
Compare
marcins
force-pushed
the
mszczepanski/insource-source-map
branch
2 times, most recently
from
c5cb7e0 to
fd073fc
Compare
marcins
force-pushed
the
mszczepanski/insource-source-map
branch
from
fd073fc to
8b7ca45
Compare
In sources the @parcel/source-map Rust and JavaScript code into Atlaspack, and updates all of the usages. Introduces a `safeToBuffer` method to ensure that any Parcel sourcemaps don't cause problems from the outside.
marcins
force-pushed
the
mszczepanski/insource-source-map
branch
from
8b7ca45 to
566bde7
Compare
Contributor
📊 Benchmark Results🎉 Performance improvements detected! 📊 Benchmark ResultsOverall Performance
🔍 Detailed Phase AnalysisThree.js Real Repository (JS)
Three.js Real Repository (Native)
💾 Unified Memory AnalysisThree.js Real Repository (JS) Memory Statistics
Sample Counts: JS: 6, Native: 262 Three.js Real Repository (Native) Memory Statistics
Sample Counts: JS: 6, Native: 510 🖥️ Environment
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As this change touches a lot of files, I've done a Loom overview to highlight the important parts: https://www.loom.com/share/432549b7b21545a49e78829c13bb2206?sid=4887a78a-df6d-4b77-82a4-803ea6393e55
Motivation
We want to interate / experiment with changes to source maps, and currently as an external library this is complicated. If we in-source the source map library we are free to make breaking changes that suit our use cases and Atlaspack more directly.
Changes
parcel_sourcemapparcel_sourcemapfor the native CSS Transformer as it expects aparcel_sourcemapas input@atlaspack/source-mappackage that is what@parcel/source-mapwasChecklist
docs/folder