Skip to content

Conversation

@n2p5
Copy link
Contributor

@n2p5 n2p5 commented Sep 2, 2025

Description

DRAFT: WIP, this is an experimental ICS1 integration that we are testing out. It is not ready for-prime-time, but is here to give visiability to the work in progress for the ICS1 changes we're tracking in https://github.com/allinbits/interchain-security.

You can track those changes here: allinbits/interchain-security#2

TODO:

  • update documentation to properly explain this change
  • add e2e testing to demonstrate how ICS1 works with AtomOne

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Included the correct type prefix in the PR title
  • Added ! to the type prefix if API, client, or state breaking change (i.e., requires minor or major version bump)
  • Targeted the correct branch (see PR Targeting)
  • Provided a link to the relevant issue or specification
  • Followed the guidelines for building SDK modules
  • Included the necessary unit and integration tests
  • Added a changelog entry in .changelog (for details, see contributing guidelines)
  • Included comments for documenting Go code
  • Updated the relevant documentation or specification
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the Stale label Oct 20, 2025
@giunatale giunatale removed the Stale label Oct 21, 2025
@n2p5
Copy link
Contributor Author

n2p5 commented Oct 29, 2025

Closing this Draft PR in favor of our newer implementation here: #240

@n2p5 n2p5 closed this Oct 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants