-
Notifications
You must be signed in to change notification settings - Fork 51
Feature/add openurl support #685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
trevordunn
wants to merge
17
commits into
auth0:main
Choose a base branch
from
trevordunn:feature/add-openurl-support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allowInterop can be used multiple times on the same function without adverse effects, so it is ok if the user also passes a function that has already been "interoped"
CONFLICT (content): Merge conflict in: - auth0_flutter/lib/auth0_flutter_web.dart - auth0_flutter/lib/src/web/auth0_flutter_plugin_real.dart - auth0_flutter/lib/src/web/js_interop.dart - auth0_flutter/test/web/auth0_flutter_web_test.mocks.dart - auth0_flutter_platform_interface/lib/src/login_options.dart
Author
|
Stalled on finishing this until #686 is resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of #393, which seems to have gone stale.
📋 Changes
openUrlparameter in bothloginWithRedirectandlogouton the browser version.openUrlrequires auth0-spa-js version2.0.1or later.This is important to me due to the @microsoft/teams-js library necessary to do authentication inside microsoft teams, reference docs here
In short, it handles authentication in its own window.
My use case would be something similar to
🎯 Testing
2.0to2.0.1atauth0_flutter/example/web/index.htmlloginWithRedirectandlogoutfunctionsPossible concerns
While manual testing, you will also see two errors in the web console:
Error: Promise was rejected with a value of 'undefined'TypeError: T.as is not a functionFrom my tests, this seems be comming out of the main
auth0-spa-jslibrary due to unhandled rejections, and doesn't affect the usage ofauth0_flutteritself. Though it would require a deeper research on why it is happening.