Skip to content

virsh_domjobinfo: fix pipe file read stuck when background virsh cmd failed #6564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

virsh_domjobinfo: fix pipe file read stuck when background virsh cmd failed #6564

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions libvirt/tests/src/virsh_cmd/domain/virsh_domjobinfo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,14 @@ def cmp_jobinfo(result, info_list, job_type, actions):
else:
process = get_subprocess(action, vm_name, tmp_pipe, None)

try:
_, stderr = process.communicate(timeout=6)
if process.returncode:
os.unlink(tmp_pipe)
test.error('Background cmd met unexpected failure of %s, abort the test.' % stderr)
except subprocess.TimeoutExpired:
logging.debug("Background cmd is still running.")

f = open(tmp_pipe, 'rb')
dummy = f.read(1024 * 1024).decode(locale.getpreferredencoding(), 'ignore')

Expand Down