Skip to content

Conversation

@ARR4N
Copy link
Contributor

@ARR4N ARR4N commented Oct 23, 2025

Why this should be merged

Provides a single point of entry for emulation of coreth and subnet-evm behaviour with respect to temporary libevm registration.

How this works

Syntactic sugar. The changes to go.mod are simply due to running go get at the latest commits on `master.

Note

Open question: this adds subnet-evm to go.mod. Do we want to actively block its import in any other package?

How this was tested

Basic integration test to demonstrate usage of the functions with respective repo "extra" types.

Need to be documented in RELEASES.md?

No

@ARR4N ARR4N marked this pull request as ready for review October 23, 2025 17:07
@Copilot Copilot AI review requested due to automatic review settings October 23, 2025 17:07
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces an emulate package that provides syntactic sugar for temporarily registering libevm extras to emulate coreth (C-Chain) and subnet-evm behavior. The package offers wrapper functions that handle temporary registration for both error-only and value-returning operations, enabling consistent emulation across the codebase.

Key Changes:

  • New emulate package with functions for temporary libevm registration
  • Integration test demonstrating concurrent usage with both coreth and subnet-evm
  • Updated dependencies to latest commits on master for coreth, libevm, and newly added subnet-evm

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.

File Description
vms/evm/emulate/emulate.go Core emulation wrapper functions for both repos with error-only and value-returning variants
vms/evm/emulate/emulate_test.go Integration test verifying concurrent emulation behavior and mutual exclusion
go.mod Dependency updates including new subnet-evm dependency and version bumps for related packages

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@ARR4N ARR4N self-assigned this Oct 23, 2025
Co-authored-by: Copilot <[email protected]>
Signed-off-by: Arran Schlosberg <[email protected]>
Co-authored-by: Stephen Buttolph <[email protected]>
Signed-off-by: Arran Schlosberg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

3 participants