Skip to content

style: enable errcheck linter #1203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 47 commits into
base: master
Choose a base branch
from
Open

style: enable errcheck linter #1203

wants to merge 47 commits into from
+68 −45

Conversation

@JonathanOppenheimer
Copy link
Member

Why this should be merged

This PR works towards completing #1144.

@JonathanOppenheimer JonathanOppenheimer self-assigned this Sep 10, 2025
alarso16
alarso16 previously requested changes Sep 10, 2025
View reviewed changes
Copy link
Contributor

@alarso16 alarso16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's some repeated patterns that should be changed

JonathanOppenheimer and others added 3 commits September 10, 2025 14:52
@JonathanOppenheimer @alarso16
Update core/state_manager_test.go
8e8947d 
Co-authored-by: Austin Larson <[email protected]>
Signed-off-by: Jonathan Oppenheimer <[email protected]>
@JonathanOppenheimer @alarso16
Update plugin/evm/atomic/state/atomic_trie.go
73d6f52 
Co-authored-by: Austin Larson <[email protected]>
Signed-off-by: Jonathan Oppenheimer <[email protected]>
@JonathanOppenheimer
in-line errors
ca5e761
@JonathanOppenheimer
Copy link
Member Author

There's some repeated patterns that should be changed

I resolved these.

StephenButtolph
StephenButtolph reviewed Sep 11, 2025
View reviewed changes
JonathanOppenheimer and others added 2 commits September 11, 2025 14:15
@JonathanOppenheimer @StephenButtolph
Apply suggestions from code review
5b12fa2 
Co-authored-by: Stephen Buttolph <[email protected]>
Signed-off-by: Jonathan Oppenheimer <[email protected]>
@JonathanOppenheimer
Stephen suggestions
2b038aa
alarso16
alarso16 previously requested changes Sep 15, 2025
View reviewed changes
alarso16
alarso16 reviewed Sep 22, 2025
View reviewed changes
alarso16
alarso16 previously requested changes Oct 8, 2025
View reviewed changes
Copy link
Contributor

@alarso16 alarso16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CleanupVerified interface now always returns nil. Probably just shouldn't return anything

alarso16
alarso16 reviewed Oct 8, 2025
View reviewed changes
alarso16
alarso16 reviewed Oct 8, 2025
View reviewed changes
alarso16
alarso16 approved these changes Oct 29, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alarso16 alarso16 alarso16 approved these changes

@StephenButtolph StephenButtolph Awaiting requested review from StephenButtolph

Assignees

@JonathanOppenheimer JonathanOppenheimer

Labels

requires-subnet-evm-port

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JonathanOppenheimer @StephenButtolph @alarso16