Skip to content

Disallow extra properties in rule options #359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 18, 2025
Merged

Disallow extra properties in rule options #359

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions rules/assertion-arguments.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,19 +391,20 @@
const schema = [{
type: 'object',
properties: {
message: {

Check failure on line 394 in rules/assertion-arguments.js

View workflow job for this annotation

GitHub Actions / Node.js (^18.18) 

Schema option is missing an ajv description.
enum: [
'always',
'never',
],
default: undefined,

Check failure on line 399 in rules/assertion-arguments.js

View workflow job for this annotation

GitHub Actions / Node.js (^18.18) 

Disallowed default value in schema.
},
},
additionalProperties: false,
}];

module.exports = {
create,
meta: {

Check failure on line 407 in rules/assertion-arguments.js

View workflow job for this annotation

GitHub Actions / Node.js (^18.18) 

Rule with non-empty schema is missing a `meta.defaultOptions` property.
type: 'problem',
docs: {
description: 'Enforce passing correct arguments to assertions.',
Expand Down
1 change: 1 addition & 0 deletions rules/no-ignored-test-files.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,21 +50,22 @@
const schema = [{
type: 'object',
properties: {
extensions: {

Check failure on line 53 in rules/no-ignored-test-files.js

View workflow job for this annotation

GitHub Actions / Node.js (^18.18) 

Schema option is missing an ajv description.
type: 'array',
},
files: {

Check failure on line 56 in rules/no-ignored-test-files.js

View workflow job for this annotation

GitHub Actions / Node.js (^18.18) 

Schema option is missing an ajv description.
type: 'array',
},
helpers: {

Check failure on line 59 in rules/no-ignored-test-files.js

View workflow job for this annotation

GitHub Actions / Node.js (^18.18) 

Schema option is missing an ajv description.
type: 'array',
},
},
additionalProperties: false,
}];

module.exports = {
create,
meta: {

Check failure on line 68 in rules/no-ignored-test-files.js

View workflow job for this annotation

GitHub Actions / Node.js (^18.18) 

Rule with non-empty schema is missing a `meta.defaultOptions` property.
type: 'suggestion',
docs: {
description: 'Ensure no tests are written in ignored files.',
Expand Down
1 change: 1 addition & 0 deletions rules/no-import-test-files.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ const schema = [{
type: 'array',
},
},
additionalProperties: false,
}];

module.exports = {
Expand Down
1 change: 1 addition & 0 deletions rules/test-title-format.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ const schema = [
default: undefined,
},
},
additionalProperties: false,
},
];

Expand Down
Loading