Skip to content

Conversation

JasterV
Copy link

@JasterV JasterV commented Oct 27, 2022

  • ran tests locally with npm test (I would like some help to come up with a proper test for this new function, but from the implementation it looks kinda obvious it should work)
  • updated CHANGELOG.md if appropriate (I don't know how should I update the changelog, should I create a minor version?)

This PR comes from an issue I opened here #174

@JasterV JasterV marked this pull request as draft October 27, 2022 20:36
@JasterV JasterV marked this pull request as ready for review October 27, 2022 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant