fix: ensure thread-safe handling of streams in AWSIoT components #5520
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mattczech @lyricsboy @hughescr @orta Hey guys, anybody can help review this PR so that we can get rid of the pod patching? Thanks. |
|
@awsmobilesdk review, please~ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
None
Description of changes:
Actually I already submitted a PR several months ago, but it got declined because of the code change in it is not really able to resolve the issue, but you can get the issue details from that PR.
As for the code change in this PR, I already applied it in our release app for nearly a quarter by creating a pod patch, I can sure it's able to resolve the corresponding issue because we haven't observed the corresponding error report in both Sentry and Xcode crash statistics anymore, but I am not sure if it's the most optimal solution, so please help take a look.
Check points:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.