feat: Kubernetes recommended labels

[nlamirault]

• Support all Kubernetes recommended labels
• Refactoring using template helper.
• Support for additional labels which can be add to all resources
• Change labelSelector into metrics-service to use the same of the deployment.

[ack-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nlamirault
Once this PR has been reviewed and has the lgtm label, please assign a-hilaly for approval by writing /assign @a-hilaly in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ack-prow]

Hi @nlamirault. Thanks for your PR.

I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[knottnt]

Hi @nlamirault appreciate the contribution! In order to keep the common elements for the controller helm charts synced we use common templates in the code-generator repo. These changes should probably be done there.

[nlamirault]

@knottnt how can i test the generation of the template using the code-generator ?

[knottnt]

how can i test the generation of the template using the code-generator ?

@nlamirault Once you've updated the template files you could test locally by re-building the Helm charts of one of the ACK controller. For example from the code-generator repo the s3-controller could be rebuilt with make build-controller SERVICE=s3. You can find more info in our contributor docs.

[nlamirault]

I try this one: aws-controllers-k8s/code-generator#619

[nlamirault]

i've got this error. Any idea ?

$ export SERVICE=s3
$ make build-controller SERVICE=$SERVICE
building ack-generate ... ok.
==== building s3-controller ====
Error evaluating SERVICE_CONTROLLER_SOURCE_PATH environment variable:
/Users/nicolas.lamirault/Projects/Forks/ack-code-generator/scripts/../../s3-controller is not a directory.

Usage:
  build-controller.sh <service>

<service> should be an AWS service API aliases that you wish to build -- e.g.
's3' 'sns' or 'sqs'