improv(commons): Make trace ID access more robust #4693
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
commons
svozza
changed the title
|
sdangol
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Last week we had to revert several PRs dies to an issue with the
InvokeStoremodule. This module has now been patched.This PR re-introduces the module, which means we now fetch the X-ray trace id from
AsyncLocalStorageif it is available and an environment variable if not..Changes
Updated the
getXrayTraceDataFromEnvfunction inenvUtilsto checkAsyncLocalStoragefirst and fall back to the_X_AMZN_TRACE_IDenvironment variable otherwise.Also updated the
envUtilstests to useunstubAllEnvsrather than directly mutateprocess.env.Issue number: closes #4657
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.