Skip to content

fix requirement bug, fix server.py bug #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix requirement bug, fix server.py bug #146

wants to merge 1 commit into from

Conversation

whn09
Copy link

@whn09 whn09 commented Jul 4, 2025

Issue #, if available:

Description of changes:

  • Change requests=2.32.3 to requests==2.32.3
  • Add event_type = None and forward_task = None to websocket_handler to avoid some errors

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

prettyprettyprettygood
prettyprettyprettygood reviewed Jul 11, 2025
View reviewed changes
Copy link
Contributor

@prettyprettyprettygood prettyprettyprettygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are below lines commented?

 # elif not aws_key_id or not aws_secret:
    #     print(f"AWS_ACCESS_KEY_ID and AWS_SECRET_ACCESS_KEY are required.")

@whn09
Copy link
Author

whn09 commented Jul 11, 2025

Sorry, this is a mistake. The two lines should not be commented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prettyprettyprettygood prettyprettyprettygood prettyprettyprettygood left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@whn09 @prettyprettyprettygood