Skip to content

Conversation

chivatam
Copy link

@chivatam chivatam commented Jun 23, 2025

Issue #, if available:

Distillation example

(7B Arcee model distilled onto 1.5B Qwen model)
Description of changes:
Added a new folder within 3.testcases/pytorch

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
@nadknish and @nghtm

Copy link
Contributor

@mhuguesaws mhuguesaws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this contribution. See comments.
Also please consider adding Slurm submission script.

@nghtm nghtm requested review from nghtm and nadknish June 24, 2025 15:09
@chivatam chivatam requested review from mhuguesaws and nadknish July 3, 2025 05:46
Copy link
Collaborator

@paragao paragao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments. Docker images does not build because it cannot find setup.sh and there is no setup.sh under src/. Please, go through a clean run on a new environment and see if other things will break. Waiting on your update to move this forward.

Venkata Satyanarayana Chivatam and others added 2 commits July 28, 2025 16:05
Copy link
Contributor

@nghtm nghtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR Satya! Is this ready for review?

- Flash Attention 2.7.4
- DeepSpeed

### Installation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Provide step by step isntructions to follow in the readme, or provide a link to the FSDP Kuberentes example if it is too burdensome to maintain identical readme instructions (this might be a good idea, to reduce maintence overhead), if you are taking a dependency on the FSDP setup instructions

@chivatam
Copy link
Author

@nghtm Yes, I am working with @paragao on this! I added all the suggested changes and support for FSx. It is ready be reviewed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants