Fix AMI cleanup workflow to deregister AMI before deleting snapshots #238
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the Step Functions state machine for AMI cleanup (issue #171). The current implementation attempts to delete snapshots in parallel with deregistering AMIs, which causes errors since snapshots that are in use by AMIs cannot be deleted.
Changes
asl.jsonto ensure that AMIs are deregistered before attempting to delete their associated snapshotsThis change ensures that snapshots are only deleted after the AMI has been successfully deregistered, which should resolve the error:
Fixes #171