Adding prometheus metrics via PMD test #548
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Paramadon
force-pushed
the
paramadon/add-pmd-prometheus
branch
from
4731767 to
b8876e6
Compare
dricross
reviewed
Jun 30, 2025
Comment on lines
+102
to
+107
| dims, failed := t.DimensionFactory.GetDimensions([]dimension.Instruction{ | ||
| { | ||
| Key: "InstanceId", | ||
| Value: dimension.ExpectedDimensionValue{aws.String(awsservice.GetInstanceId())}, | ||
| }, | ||
| }) |
There was a problem hiding this comment.
There are some more dimensions we should probably check the values of as part of this test
There was a problem hiding this comment.
Very cool tool! Great addition to have
| // Validate based on metric type | ||
| switch metricName { | ||
| case "prometheus_test_histogram": | ||
| // For histogram, values should be between 0-10 |
There was a problem hiding this comment.
Is it possible to be more strict on the histogram values rather than just checking min/max? I think we'd at least want to check sum/sample count too so those are all parts of the StatisticsSet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue
Currently customers cannot send prometheus metrics via pmd so in order to be able to do that we need an integ test to verify that we get prometheus metrics via pmd.
Description of changes
Added agent change to add cloudwatch as a destination in prometheus pipeline in this pr: aws/amazon-cloudwatch-agent#1742.
Ran an integ test against the agent branch that is in the above pr (prometheusPMDSupport) on this test branch here is the passing test: https://github.com/aws/amazon-cloudwatch-agent/actions/runs/15905800422/job/44860425431