Update workflow for workload discovery integration tests #1916
+479
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
musa-asad
added
the
ready for testing
musa-asad
force-pushed
the
musa-asad/feature/workload-discovery
branch
2 times, most recently
from
464860e to
dcb9bb7
Compare
musa-asad
force-pushed
the
musa-asad/feature/workload-discovery
branch
from
7d6a7f3 to
0c4c260
Compare
musa-asad
commented
Oct 21, 2025
lisguo
reviewed
Oct 23, 2025
musa-asad
force-pushed
the
musa-asad/feature/workload-discovery
branch
from
0a27ab1 to
10d06a3
Compare
lisguo
previously approved these changes
Oct 24, 2025
musa-asad
force-pushed
the
musa-asad/feature/workload-discovery
branch
from
5be6c50 to
2a257f8
Compare
musa-asad
force-pushed
the
musa-asad/feature/workload-discovery
branch
2 times, most recently
from
fe64d14 to
fa76598
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
musa-asad
force-pushed
the
musa-asad/feature/workload-discovery
branch
3 times, most recently
from
5f9b024 to
2b99647
Compare
musa-asad
force-pushed
the
musa-asad/feature/workload-discovery
branch
from
2b99647 to
d08f08e
Compare
lisguo
approved these changes
Oct 27, 2025
| runs-on: ubuntu-latest | ||
| outputs: | ||
| ec2_linux_wd_matrix: ${{ steps.set-matrix.outputs.ec2_linux_wd_matrix }} | ||
| ec2_linux_wd_nvidia_matrix: ${{ steps.set-matrix.outputs.ec2_linux_wd_nvidia_matrix }} |
There was a problem hiding this comment.
why is nvidia different from the regular wd_matrix?
Is it to be distinct with the devices? then maybe it should be device matrix?
There was a problem hiding this comment.
Because NVIDIA uses GPU instance types. Other devices may have their own device instance type.
jefchien
reviewed
Oct 27, 2025
| env: | ||
| GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
|
|
||
| StartWDIntegrationTests: |
There was a problem hiding this comment.
nit: WD isn't very descriptive.
Suggested change
| StartWDIntegrationTests: | |
| StartWorkloadDiscoveryIntegrationTests: |
| echo "ec2_windows_wd_matrix=$(echo $(cat generator/resources/ec2_windows_wd_complete_test_matrix.json))" >> "$GITHUB_OUTPUT" | ||
| echo "ec2_windows_wd_nvidia_matrix=$(echo $(cat generator/resources/ec2_windows_wd_nvidia_complete_test_matrix.json))" >> "$GITHUB_OUTPUT" | ||
| StartLocalStack: |
There was a problem hiding this comment.
Why do we need a LocalStack for the workload discovery tests?
| env: | ||
| GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| OutputEnvVariables: |
There was a problem hiding this comment.
nit: Why do we need this? Seems like the jobs should be able to get the variables directly from the inputs/env contexts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue
New workload discovery integration tests are implemented in aws/amazon-cloudwatch-agent-test#608, but there is no mechanism to trigger these tests.
Description of changes
wd-integration-test.ymlworkflow for Workload Discovery (WD) integration testsEC2LinuxWDIntegrationTest- Base Linux WD testsEC2WindowsWDIntegrationTest- Base Windows WD testsEC2NvidiaLinuxWDIntegrationTest- NVIDIA Linux WD testsEC2NvidiaWindowsWDIntegrationTest- NVIDIA Windows WD testsbuild-test-artifacts.ymlto support WD test workflow triggeringLicense
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Requirements
Before commiting your code, please do the following steps.
make fmtandmake fmt-shmake lintIntegration Tests
To run integration tests against this PR, add the
ready for testinglabel.