fix:bug(checkpoint): fix crashes when truncating checkpoint message #3137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Similar Pull Request(UTF-8 boundary issue): #3087 |
kensave
approved these changes
Oct 9, 2025
evanliu048
approved these changes
Oct 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #3136
Description of changes:
When using checkpoint features, the user’s prompt is truncated through the
truncate_messagefunction. This function trims the prompt with a substring if its length is too long (length: 60).However, in the case of multibyte characters such as those in CJK languages, if a character is cut across a UTF-8 boundary, a panic occurs and the program terminates.
This PR removes such crashes and fixes the truncate_message so that it works correctly.
Screen Capture