Skip to content

feat: allow raw keyrings to decrypt with multiple wrapping keys #485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat: allow raw keyrings to decrypt with multiple wrapping keys #485

wants to merge 4 commits into from

Conversation

kessplas
Copy link
Contributor

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Check any applicable:

  • Were any files moved? Moving files changes their URL, which breaks all hyperlinks to the files.

@kessplas kessplas marked this pull request as ready for review September 3, 2025 21:50
@kessplas kessplas requested a review from a team as a code owner September 3, 2025 21:50
lucasmcdonald3
lucasmcdonald3 approved these changes Sep 10, 2025
View reviewed changes
Copy link
Contributor

@lucasmcdonald3 lucasmcdonald3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- I struggled to understand how the title of the PR connected to the content, but eventually understood. I think that moving one (or some) of the tests that decrypt with multiple wrapping keys into examples could be helpful but not totally necessary.

@janSchumacherPayments
Copy link

LGTM -- I struggled to understand how the title of the PR connected to the content, but eventually understood. I think that moving one (or some) of the tests that decrypt with multiple wrapping keys into examples could be helpful but not totally necessary.

I would love to see that. Thats a critical feature IMO

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasmcdonald3 lucasmcdonald3 lucasmcdonald3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kessplas @janSchumacherPayments @lucasmcdonald3