fix: parameterized queries #528
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karenc-bq
force-pushed
the
fix/parameterized-queries
branch
6 times, most recently
from
2deb472 to
182e682
Compare
karenc-bq
commented
Aug 19, 2025
| @@ -5,6 +5,7 @@ on: | |||
| push: | |||
| branches: | |||
| - main | |||
| - fix/parameterized-queries | |||
There was a problem hiding this comment.
Will remove before merging
karenc-bq
force-pushed
the
fix/parameterized-queries
branch
from
182e682 to
2dc2a57
Compare
sophia-bq
reviewed
Aug 20, 2025
| private async updateState(client: any, options: string | QueryOptions, values?: any): Promise<any> { | ||
| let sql: string; | ||
| if (typeof options === "string") { | ||
| sql = client.format(options, values); |
There was a problem hiding this comment.
Might be important to add some sort of null check for client before calling client.format?
| ); | ||
|
|
||
| itIfPG( | ||
| "pg parameterized query with QueryConfig", |
There was a problem hiding this comment.
Can there also be a test for QueryArrayConfig?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add missing API from community drivers.
Update clients to make it more clear which methods are from community drivers and which ones are wrapper-specific
Description
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.