Skip to content

Conversation

mazyu36
Copy link
Contributor

@mazyu36 mazyu36 commented Jul 30, 2025

Issue # (if applicable)

N/A

Reason for this change

Add missing property.

Description of changes

Add deleteAutomatedBackups property.

Describe any new or updated permissions being added

N/A

Description of how you validated changes

Add unit tests and an integ test.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team July 30, 2025 11:05
@github-actions github-actions bot added p2 distinguished-contributor [Pilot] contributed 50+ PRs to the CDK labels Jul 30, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@aws-cdk-automation aws-cdk-automation dismissed their stale review July 31, 2025 12:33

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@mazyu36 mazyu36 marked this pull request as ready for review July 31, 2025 13:18
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: c440eda
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jul 31, 2025
@kumsmrit kumsmrit self-assigned this Aug 26, 2025
Copy link

@kumsmrit kumsmrit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution; I have added a minor comment.

@@ -147,6 +147,19 @@ new rds.DatabaseCluster(this, 'DatabaseCluster', {
});
```

By default, automated backups are retained after a database cluster is deleted. You can configure whether to immediately remove the automated backups when the DB cluster is deleted by setting the `deleteAutomatedBackups` property:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to contradict the default behavior, since the default is to remove automated backups immediately after the DB cluster is deleted, unless the AWS Backup policy specifies a point-in-time restore rule as per CFN documentation

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦‍♂️ I wrote complete wrong. Fixed it now. Thanks!

@mazyu36 mazyu36 requested a review from kumsmrit August 28, 2025 15:20
@mazyu36
Copy link
Contributor Author

mazyu36 commented Sep 3, 2025

duplicate #35372

@mazyu36 mazyu36 closed this Sep 3, 2025
Copy link
Contributor

github-actions bot commented Sep 3, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
distinguished-contributor [Pilot] contributed 50+ PRs to the CDK p2 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants