Skip to content

Conversation

dil-bagoston
Copy link

@dil-bagoston dil-bagoston commented Aug 6, 2025

Issue # (if applicable)

Closes #.

Reason for this change

Currently the dbProxyName property returns a non lowecased value, which is incorrect because in AWS proxy resources are lowercased

Description of changes

Lowercased the returned reference from Cloudformation and added testcases to verify the change

Describe any new or updated permissions being added

No extra permissions added

Description of how you validated changes

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2 labels Aug 6, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team August 6, 2025 09:46
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter fails with the following errors:

❌ Fixes must contain a change to a test file.
❌ Fixes must contain a change to an integration test file and the resulting snapshot.

If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed, add Clarification Request to a comment.

@dil-bagoston dil-bagoston changed the title bugfix: convert returned dbProxyNAme to lowercase and add tst cases fix: convert returned dbProxyNAme to lowercase and add tst cases Aug 6, 2025
@dil-bagoston dil-bagoston changed the title fix: convert returned dbProxyNAme to lowercase and add tst cases fix: convert returned dbProxyName to lowercase and add test cases Aug 6, 2025
@dil-bagoston dil-bagoston changed the title fix: convert returned dbProxyName to lowercase and add test cases fix: convert returned dbProxyName to lowercase Aug 6, 2025
@dil-bagoston dil-bagoston changed the title fix: convert returned dbProxyName to lowercase fix(rds): convert returned dbProxyName to lowercase Aug 7, 2025
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 5025fcb
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. Note that PRs with failing linting check or builds are not reviewed, please ensure your build is passing

To prevent automatic closure:

  • Resume work on the PR
  • OR request an exemption by adding a comment containing 'Exemption Request' with justification e.x "Exemption Request: "
  • OR request clarification by adding a comment containing 'Clarification Request' with a question e.x "Clarification Request: "

This PR will automatically close in 14 days if no action is taken.

@aws-cdk-automation
Copy link
Collaborator

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

@aws-cdk-automation aws-cdk-automation added the closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. label Sep 12, 2025
Copy link
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants