Skip to content

Conversation

otaviomacedo
Copy link
Contributor

In this test, the platform specified to bundle the asset is linux/amd64. But the image used doesn't specify any platform. This is causing the integ.assets.bundling.docker-opts.ts to fail with the message:

Unable to find image 'cdk-66687611b68d3de0f92ed971e4c457e4828f2e0c877c8b1f5fab42ac3d2772ec:latest' locally
docker: Error response from daemon: pull access denied for cdk-66687611b68d3de0f92ed971e4c457e4828f2e0c877c8b1f5fab42ac3d2772ec, repository does not exist or may require 'docker login'

Run 'docker run --help' for more information

Add the platform to the build parameters of the Docker image.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team August 13, 2025 12:55
@github-actions github-actions bot added the p2 label Aug 13, 2025
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Aug 13, 2025
@ozelalisen
Copy link
Member

Does this not require snapshots to be updated?

Copy link
Contributor

mergify bot commented Sep 2, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Copy link
Contributor

mergify bot commented Sep 2, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 382ff54 into main Sep 2, 2025
18 checks passed
@mergify mergify bot deleted the otaviom/fix-asset-bundling-integ-test branch September 2, 2025 13:00
Copy link
Contributor

github-actions bot commented Sep 2, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants