Skip to content

fix(elasticache): cannot import Redis 7 serverless cache #35629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
+30 −4
Open

fix(elasticache): cannot import Redis 7 serverless cache #35629

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
41fd532
fix(elasticache): cannot import Redis 7 Serverless Cache
mazyu36 Sep 30, 2025
701f224
Merge branch 'main' into fix/import_redis_7
mazyu36 Sep 30, 2025
aa9c983
Merge branch 'main' into fix/import_redis_7
mazyu36 Sep 30, 2025
9c03319
Merge branch 'main' into fix/import_redis_7
mazyu36 Oct 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/@aws-cdk/aws-elasticache-alpha/lib/serverless-cache.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,6 +329,7 @@ export class ServerlessCache extends ServerlessCacheBase {
case CacheEngine.VALKEY_7:
case CacheEngine.VALKEY_8:
case CacheEngine.REDIS_LATEST:
case CacheEngine.REDIS_7:
// Document showing the default port
// https://docs.aws.amazon.com/AmazonElastiCache/latest/dg/set-up.html#elasticache-install-grant-access-VPN
defaultPort = ec2.Port.tcp(6379);
Expand Down
33 changes: 29 additions & 4 deletions packages/@aws-cdk/aws-elasticache-alpha/test/serverless-cache.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,22 @@ describe('serverless cache', () => {
expect(cache.serverlessCacheArn).toEqual(`arn:${stack.partition}:elasticache:${stack.region}:${stack.account}:serverlesscache/my-serverless-cache`);
});

test.each([
[CacheEngine.VALKEY_LATEST],
[CacheEngine.VALKEY_8],
[CacheEngine.VALKEY_7],
[CacheEngine.REDIS_LATEST],
[CacheEngine.REDIS_7],
[CacheEngine.MEMCACHED_LATEST],
])('import serverless cache for %s', (cacheEngine) => {
const cache = ServerlessCache.fromServerlessCacheAttributes(stack, 'ImportedCache', {
serverlessCacheName: 'my-serverless-cache',
engine: cacheEngine,
});

expect(cache.serverlessCacheArn).toEqual(`arn:${stack.partition}:elasticache:${stack.region}:${stack.account}:serverlesscache/my-serverless-cache`);
});

test('create serverless cache with full props', () => {
const key = new Key(stack, 'Key', {});
const securityGroup = new SecurityGroup(stack, 'SecurityGroup', { vpc });
Expand Down Expand Up @@ -73,15 +89,24 @@ describe('serverless cache', () => {
});
});

test('create serverless cache with VALKEY_LATEST enigne', () => {
test.each([
[CacheEngine.VALKEY_LATEST, 'valkey', Match.absent()],
[CacheEngine.VALKEY_8, 'valkey', '8'],
[CacheEngine.VALKEY_7, 'valkey', '7'],
[CacheEngine.REDIS_LATEST, 'redis', Match.absent()],
[CacheEngine.REDIS_7, 'redis', '7'],
[CacheEngine.MEMCACHED_LATEST, 'memcached', Match.absent()],
])('test serverless cache version for %s', (cacheEngine, engine, version) => {
new ServerlessCache(stack, 'Cache', {
description: 'Serverless cache',
vpc,
engine: CacheEngine.VALKEY_LATEST,
engine: cacheEngine,
});

Template.fromStack(stack).hasResourceProperties('AWS::ElastiCache::ServerlessCache', {
Engine: 'valkey',
MajorEngineVersion: Match.absent(),
Description: 'Serverless cache',
Engine: engine,
MajorEngineVersion: version,
});
});
});
Expand Down
Loading