chore: bump TypeScript/jsii to 5.9 #35658
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrgrain
approved these changes
Oct 3, 2025
rix0rrr
changed the title
mrgrain
reviewed
Oct 3, 2025
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upgrades jsii to a version with support for type intersections.
Changes around decorators:
experimentalDecorators: trueanymore by default, we need to update the typing for the@MethodMetadatadecorator (ref).framework-integpackage can see the source.tsfiles fromaws-cdk-lib, it can see the presence of the decorators. The code must type check, so we must switchexperimentalDecoratorsto the same value in that package (false). Some example code used a legacy decorator which had to be rewritten to be somewhat equivalent: the exact example cannot be recreated with modern decorators.static { }JS syntax if available in ES2022+, or tries to emulate that syntax). If the behavior is emulated, theCONSTRUCT_INJECTION_IDproperty can never be read from the class -- it always shows up asundefined. Upgrade to ES2022 across the board to generate the right polyfill code. This is supported by Node 16+.I also bumped the Node type definitions, which led to a couple more eslint violations that needed to be fixed.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license