-
Notifications
You must be signed in to change notification settings - Fork 4.3k
feat: adding controlPlaneScalingConfig to Cluster #36302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: adding controlPlaneScalingConfig to Cluster #36302
Conversation
aws-cdk-automation
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter fails with the following errors:
❌ Features must contain a change to an integration test file and the resulting snapshot.
If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed, add Clarification Request to a comment.
28177dc to
572af5d
Compare
a7a063d to
e060d94
Compare
|
||||||||||||||
|
||||||||||||||
|
I am able to get this build to succeed locally in devcontainer. Unfortunately, I am struggling with the integ tests to generate the new snapshot. It is unable to find the integ test files. I used the below command bc the command documented in the contributing guide Can a maintainer run the integ test and update the snapshot for me? |
Reason for this change
controlPlaneScalingConfigwas an option added to EKS clusters recently. This was added to CFN and the level 1 structure. This PR adds it to the level 2 construct.Description of changes
Describe any new or updated permissions being added
None
Description of how you validated changes
Tested with unit tests. CFN side changes have been tested separately and this change is not doing anything more than just passing through the level 1 cfnCluster properties.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license