Skip to content

Conversation

@notSoWiseOldMan
Copy link

@notSoWiseOldMan notSoWiseOldMan commented Dec 4, 2025

Reason for this change

controlPlaneScalingConfig was an option added to EKS clusters recently. This was added to CFN and the level 1 structure. This PR adds it to the level 2 construct.

Description of changes

  • Added controlPlaneScalingConfig to Cluster.
  • Added section to the README
  • Added unit tests for basic controlPlaneScalingConfig validation

Describe any new or updated permissions being added

None

Description of how you validated changes

Tested with unit tests. CFN side changes have been tested separately and this change is not doing anything more than just passing through the level 1 cfnCluster properties.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team December 4, 2025 23:08
@github-actions github-actions bot added p2 beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK labels Dec 4, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter fails with the following errors:

❌ Features must contain a change to an integration test file and the resulting snapshot.

If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed, add Clarification Request to a comment.

@notSoWiseOldMan notSoWiseOldMan force-pushed the eks/controlPlaneScalingConfig branch from a7a063d to e060d94 Compare December 8, 2025 16:42
@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2025

TestsPassed ❌️SkippedFailed
Security Guardian Results
TestResult
No test annotations available

@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2025

TestsPassed ❌️SkippedFailed
Security Guardian Results with resolved templates
TestResult
No test annotations available

@notSoWiseOldMan
Copy link
Author

I am able to get this build to succeed locally in devcontainer. Unfortunately, I am struggling with the integ tests to generate the new snapshot. It is unable to find the integ test files. I used the below command bc the command documented in the contributing guide yarn integ integ.eks-cluster.js fails with error Command "integ" not found.

➜  aws-cdk git:(eks/controlPlaneScalingConfig) npx integ-runner packages/@aws-cdk-testing/framework-integ/test/aws-eks/test/integ.eks-cluster.ts --update-on-failed
No such integ test: packages/@aws-cdk-testing/framework-integ/test/aws-eks/test/integ.eks-cluster.ts
Available tests: 

Verifying integration test snapshots...


Snapshot Results: 

Tests:    0 passed, 0 total

Running integration tests for failed tests...

Running in parallel across regions: us-east-1, us-east-2, us-west-2

Test Results: 

Tests:    0 passed, 0 total

Can a maintainer run the integ test and update the snapshot for me?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants