Update readme to add windows 2019 deprecation notice #1193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add windows 2019 deprecation notice in readme
LikithaVemulapalli
requested changes
Sep 15, 2025
|
|
||
| You can run the termination handler on any Kubernetes cluster running on AWS, including self-managed clusters and those created with Amazon [Elastic Kubernetes Service](https://docs.aws.amazon.com/eks/latest/userguide/what-is-eks.html). If you're using [EKS managed node groups](https://docs.aws.amazon.com/eks/latest/userguide/managed-node-groups.html), you don't need the aws-node-termination-handler. | ||
|
|
||
| > Notice: Windows Server 2019 support has been removed to align with GitHub's deprecation schedule (end date: June 30, 2025). You can continue using other supported Windows versions. |
There was a problem hiding this comment.
I feel like we also need to include the GitHub link for GitHub Actions windows deprecation this one so that customers can view the actual issue - Deprecation.
Instead of Notice: have it like a Note with symbol as this is related to deprecation something like this with ⚠️ Note
Also mention GitHub Actions do not support windows 2019 anymore.
Do not mention other supported windows versions. This is not related to all the windows versions we have windows 2019 and 2022 in our Github Actions workflows, you can suggest them to shift to windows 2022.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: 1182
Description of changes:
How you tested your changes:
Environment (Linux / Windows):
Kubernetes Version:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.