Skip to content

Fix OpenRewrite Method Matcher Syntax #6438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 23, 2025
Merged

Fix OpenRewrite Method Matcher Syntax #6438

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0493683
add missing ')' to OpenRewrite Mathod Matcher
MBoegers Sep 22, 2025
7afa63f
add missing ')' to OpenRewrite Method Matcher
davidh44 Sep 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changes/next-release/bugfix-AWSSDKforJavav2MigrationTool-8cf1e83.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"type": "bugfix",
"category": "AWS SDK for Java v2 Migration Tool",
"contributor": "MBoegers",
"description": "Fix OpenRewrite recipe MethodMatcher"
}
2 changes: 1 addition & 1 deletion v2-migration/src/main/java/software/amazon/awssdk/v2migration/S3AddImportsAndComments.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
public class S3AddImportsAndComments extends Recipe {

private static final MethodMatcher CREATE_BUCKET = v1S3MethodMatcher("createBucket(String, "
+ V1_S3_MODEL_PKG + "Region");
+ V1_S3_MODEL_PKG + "Region)");
private static final MethodMatcher LIST_NEXT_BATCH_OBJECTS = v1S3MethodMatcher("listNextBatchOfObjects(..)");
private static final MethodMatcher LIST_NEXT_BATCH_VERSIONS = v1S3MethodMatcher("listNextBatchOfVersions(..)");
private static final MethodMatcher GET_METADATA = v1S3MethodMatcher("getCachedResponseMetadata(..)");
Expand Down
2 changes: 1 addition & 1 deletion ...igration/src/main/java/software/amazon/awssdk/v2migration/TransferManagerMethodsToV2.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ public class TransferManagerMethodsToV2 extends Recipe {
private static final MethodMatcher COPY_REQUEST =
v2TmMethodMatcher(String.format("copy(%sCopyObjectRequest)", V2_S3_MODEL_PKG));
private static final MethodMatcher COPY_BUCKET_KEY =
v2TmMethodMatcher("copy(String, String, String, String");
v2TmMethodMatcher("copy(String, String, String, String)");

private static final MethodMatcher DOWNLOAD_DIR = v2TmMethodMatcher("downloadDirectory(String, String, java.io.File)");

Expand Down
Loading