Minor refactoring on auth scheme provider: rename ModeledAuthSchemePr… #6547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ovider to FallbackAuthSchemeProvider and add documentations
zoewangg
force-pushed
the
zoewang/codegenAuthSchemeRefactoring
branch
from
85bb21c to
42f3948
Compare
zoewangg
added
the
changelog-not-required
Contributor
Author
|
Changelog is not required because this is not customer-facing change (renaming an internal API) |
dagnir
reviewed
Nov 5, 2025
...n/java/software/amazon/awssdk/codegen/poet/auth/scheme/ModelBasedAuthSchemeProviderSpec.java
Outdated
Show resolved
Hide resolved
dagnir
approved these changes
Nov 5, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
|
This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ovider to FallbackAuthSchemeProvider and add documentations
Motivation and Context
No logic change, just refactored the code to rename
Modeled{Service}AuthSchemeProvider(Internal API used by services with endpoint-based auth) toFallback{Service}AuthSchemeProviderto make it clear it's served as a fallback.eg:
ModeledS3AuthSchemeProvider->FallbackS3AuthSchemeProviderAlso added documentation