Moving copying UserAgentDetails from the OriginalRequest to HttpHandler #4021
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
RequestContext.UserAgentDetails
was created, andOriginalRequest.UserAgentDetails
was copied to it as part of the getter. In some cases, this property is not accessed until the marshaller pipeline hanlder, which happens before theBeforeRequestEvent
callback. This causesRequestContext.UserAgentDetails
to miss the changes made to the original request inBeforeRequestEvent
.This PR moves the copying of
UserAgentDetails
from the OriginalRequest toHttpHandler
, which is the final step before sending the request.Testing
DRY_RUN-369ec115-0587-4ec8-ad09-a550c84d8cf6
UserAgentDetails
is copied correctly from the original request.BeforeRequestEvent
callback and made sure it applies correctly.Screenshots (if appropriate)
Types of changes
Checklist
License