feat: optional pending state for ContextCommand #652
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Can we please add more description for the introduction of this flag? |
This was referenced Aug 5, 2025
manodnyab
approved these changes
Aug 5, 2025
avi-alpert
reviewed
Aug 6, 2025
avi-alpert
approved these changes
Aug 12, 2025
manodnyab
approved these changes
Aug 12, 2025
manodnyab
approved these changes
Aug 18, 2025
This was referenced Sep 25, 2025
XiaoxuanLu
added a commit
that referenced
this pull request
Sep 29, 2025
## Problem In large workspaces, indexing can take a long time with no indication of status ## Solution An optional pending flag is added to ContextCommand definition type. This allows a pending state to be indicated before the Context Command is sent to the client. The ui can then interpret this pending flag to grey out and disable the context command Should be merged before aws/mynah-ui#421 and aws/language-servers#2060 <!--- REMINDER: - Read CONTRIBUTING.md first. - Add test coverage for your changes. - Link to related issues/commits. - Testing: how did you test your changes? - Screenshots if applicable --> **This pr is a replacement of the #652 ## License By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. --------- Co-authored-by: Conor Stewart <[email protected]> Co-authored-by: constewart9 <[email protected]> Co-authored-by: manodnyab <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In large workspaces, indexing can take a long time with no indication of status
Solution
An optional pending flag is added to ContextCommand definition type. This allows a pending state to be indicated before the Context Command is sent to the client. The ui can then interpret this pending flag to grey out and disable the context command
Should be merged before aws/mynah-ui#421 and aws/language-servers#2060
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.