Feature/js mlops telemetry #5268
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohamedzeidan2021
temporarily deployed
to
manual-approval
GitHub Actions
Inactive
rsareddy0329
reviewed
Sep 5, 2025
| This class sets defaults based on the model ID and version. | ||
| """ | ||
|
|
||
| @_telemetry_emitter(feature=Feature.JUMPSTART, func_name="jumpstart_model.create") |
There was a problem hiding this comment.
For Jumpstart, we might need to add for Jumpstart estimator as well: https://github.com/aws/sagemaker-python-sdk/blob/master/src/sagemaker/jumpstart/estimator.py
There was a problem hiding this comment.
just added
| ESTIMATOR = 5 | ||
| HYPERPOD = 6 # Added to support telemetry in sagemaker-hyperpod-cli | ||
| # Note: HyperPod CLI uses codes 6 and 7 | ||
| JUMPSTART = 8 # Added to support JumpStart telemetry |
There was a problem hiding this comment.
Make sure that this value does not coincide with Hyperpod V2 as well, which is WIP
There was a problem hiding this comment.
yes, ive talked to avi about it.
mohamedzeidan2021
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
rsareddy0329
previously approved these changes
Sep 5, 2025
mohamedzeidan2021
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
mollyheamazon
previously approved these changes
Sep 5, 2025
mohamedzeidan2021
dismissed stale reviews from mollyheamazon and rsareddy0329
via
d42b0d7
mohamedzeidan2021
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Adding Jumpstart and MLOps into telemetry
Testing done:
Currently waiting for
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
unique_name_from_baseto create resource names in integ tests (if appropriate)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.