fix(aws-documentation-mcp-server): Fix get_available_services endpoint #1796
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A change was recently made to the AWS CN page for available services and completely changed its format. This change is to update the tool endpoint function to continue surfacing the available services in AWS CN.
JonLim
requested review from
a team,
Lavoiedavidw and
tuanknguyen
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1796 +/- ##
==========================================
+ Coverage 90.42% 90.61% +0.19%
==========================================
Files 851 665 -186
Lines 63317 54302 -9015
Branches 10253 9038 -1215
==========================================
- Hits 57254 49207 -8047
+ Misses 3772 3101 -671
+ Partials 2291 1994 -297 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
scottschreckengaust
added
the
waiting-for-codeowners
Member
|
Consider meeting the project's code coverage |
AadityaBhoota
previously approved these changes
Nov 20, 2025
Contributor
Author
Good call, thanks @scottschreckengaust ! I've updated with better test coverage, I missed it on the initial pass, my mistake. |
tuanknguyen
reviewed
Nov 21, 2025
src/aws-documentation-mcp-server/awslabs/aws_documentation_mcp_server/server_aws_cn.py
Show resolved
Hide resolved
src/aws-documentation-mcp-server/awslabs/aws_documentation_mcp_server/server_aws_cn.py
Outdated
Show resolved
Hide resolved
Lavoiedavidw
approved these changes
Nov 24, 2025
Contributor
Lavoiedavidw
left a comment
Lavoiedavidw
left a comment
There was a problem hiding this comment.
LGTM: Looking for clarification on forward looking expectations
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 4, 2025
#1796) * fix(aws-documentation-mcp-server): Fix get_available_services endpoint A change was recently made to the AWS CN page for available services and completely changed its format. This change is to update the tool endpoint function to continue surfacing the available services in AWS CN. * fix: Updating tests to cover new functionality introduced in change * Updating object/dict access patterns to use safer approach * Using existing approach for returning/logging error messages --------- Co-authored-by: Jonathan Lim <[email protected]>
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A change was recently made to the AWS CN page for available services and completely changed its format. This change is to update the tool endpoint function to continue surfacing the available services in AWS CN.
Changes
get_available_servicestoolUser experience
Ideally, there would be no real change to the user experience, since this change is to restore functionality that was broken from a content update.
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change? N
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.