Skip to content

Conversation

@Hless
Copy link

@Hless Hless commented May 12, 2022

Added the feature, tets and documentation.

Would be a great addition for those using Dato

@Hless
Copy link
Author

Hless commented May 12, 2022

One thing to note: I slightly changed the caching key, it now includes the provider in the key (so caching is different for each source). I'm not sure if this is a useful change, but it made sense as this transformer would now service multiple sources

@Hless
Copy link
Author

Hless commented May 12, 2022

Added: resolver for DatoCmsFileField, otherwise the resolver would not be usuable for files added to other models.

README.md Outdated
## Features

* Read content of your SVG files from `gatsby-source-contentful` and `gatsby-source-filesystem`.
* Read content of your SVG files from `gatsby-source-contentful`, `gatsby-source-datcms` and `gatsby-source-filesystem`.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

@axe312ger
Copy link
Owner

Sorry I overlooked this 🙈

Could you fix the typo pls?

I'll then try to run it on my machine, as GH won't run the CI

@Hless
Copy link
Author

Hless commented Jul 21, 2022

Fixed the typo, but apparently my last few commits weren't signed properly. Have to check what happened here

@Hless
Copy link
Author

Hless commented Jul 21, 2022

Just realized I don't sign commits locally at all, is this something that is absolutely required for the merge?

@axe312ger
Copy link
Owner

Nono, its just that the CI won't run then. I'll have to test locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants