-
Notifications
You must be signed in to change notification settings - Fork 9
Feature: support for DatoCMS source #91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
One thing to note: I slightly changed the caching key, it now includes the provider in the key (so caching is different for each source). I'm not sure if this is a useful change, but it made sense as this transformer would now service multiple sources |
|
Added: resolver for DatoCmsFileField, otherwise the resolver would not be usuable for files added to other models. |
README.md
Outdated
| ## Features | ||
|
|
||
| * Read content of your SVG files from `gatsby-source-contentful` and `gatsby-source-filesystem`. | ||
| * Read content of your SVG files from `gatsby-source-contentful`, `gatsby-source-datcms` and `gatsby-source-filesystem`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo
|
Sorry I overlooked this 🙈 Could you fix the typo pls? I'll then try to run it on my machine, as GH won't run the CI |
|
Fixed the typo, but apparently my last few commits weren't signed properly. Have to check what happened here |
|
Just realized I don't sign commits locally at all, is this something that is absolutely required for the merge? |
|
Nono, its just that the CI won't run then. I'll have to test locally. |
Added the feature, tets and documentation.
Would be a great addition for those using Dato