Fix dangling pointer #170
Open
Fix dangling pointer #170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The address of the local variable controller is still referenced to by the static variable controller_ after run() is executed and controller has been deallocated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The address of the local variable
controlleris still referenced to by the static variablecontroller_afterrun()is executed and controller has been deallocated.This issue was detected in a sonarcloud run for the OGDF. It's not that problematic because
controller_should not be touched again afterrun()has been executed, but it's the only bug in bandit that sonarcloud detected so I thought that it is worth fixing. Please check whether my changes actually make sense; I'm not that familiar with the bandit code base.