Fix Revocation Handling in Subscriptions #124
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This update addresses a logic issue in subscription handling where revoked subscriptions without on-chain spend history were incorrectly treated as active.
The changes ensure that subscription revocations are properly respected, even when no spend has occurred, and improve test coverage to prevent regressions.
Summary
getPermissionStatus
to expose theisRevoked
flag so callers can distinguish between unused and revoked permissions.getSubscriptionStatus
to mark revoked subscriptions as inactive, even when no on-chain spend history exists.Testing
yarn workspace @base-org/account typecheck
yarn workspace @base-org/account test getSubscriptionStatus
yarn workspace @base-org/account test prepareSpendCallData
yarn workspace @base-org/account test getPermissionStatus
Notes
All tests passed successfully.
This fix ensures subscription revocations are consistently respected, preventing false positives in account activity status.