Skip to content

Conversation

spencerstock
Copy link
Collaborator

@spencerstock spencerstock commented Sep 18, 2025

What changed? Why?

Fixed all lint warnings in the SDK packages:

  1. Removed any types (5 occurrences):

    • browser-entry.ts: Added proper TypeScript declarations for global window object instead of using any
    • routeThroughGlobalAccount.ts: Changed Promise<any> to Promise<unknown> for better type safety
    • Signer.ts: Used proper WalletSendCallsParameters type instead of any[] for wallet_sendCalls params
    • Dialog.tsx: Used Preact's JSX.TargetedTouchEvent<HTMLDivElement> type for touch event handlers
  2. Removed unused suppression comment:

    • charge.ts: Removed unnecessary biome-ignore comment since useNetwork is not a React hook
  3. Fixed type issue:

    • Signer.ts: Fixed chainId type issue to handle undefined case properly

How was this tested?

  • Ran yarn lint to verify all warnings are resolved

How can reviewers manually test these changes?

Demo/screenshots

N/A - Code quality improvements only

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Sep 18, 2025

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@spencerstock spencerstock marked this pull request as ready for review September 18, 2025 20:34
@spencerstock spencerstock changed the title Fix lint warnings in SDK Fix lint warnings Sep 18, 2025
stephancill
stephancill previously approved these changes Sep 19, 2025
Copy link
Collaborator

@stephancill stephancill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@stephancill stephancill merged commit 8e4ea6b into master Sep 19, 2025
9 checks passed
@stephancill stephancill deleted the spencer/fix-lint-warnings branch September 19, 2025 19:12
@cb-heimdall
Copy link
Collaborator

Review Error for stephancill @ 2025-09-19 19:13:27 UTC
User failed mfa authentication, see go/mfa-help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants