Fix: payment values should use bigint #132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Heimdall Review Status
|
- Reverted unnecessary refactoring of pay.test.ts
- Reverted unnecessary type annotation in translatePayment.ts
- Kept only the essential changes converting value from hex strings ('0x0') to bigint (0n)
- Reduced diff from 511 lines to 79 lines
- Use bigint internally (0n) and convert to hex at JSON-RPC boundary - Add comment explaining the conversion for JSON-RPC compatibility - This follows modern best practices while maintaining compatibility
spencerstock
changed the title
spencerstock
changed the title
spencerstock
force-pushed
the
spencer/payment-subscription-updates
branch
from
dc16fba to
e31c79e
Compare
stephancill
approved these changes
Sep 19, 2025
fan-zhang-sv
approved these changes
Sep 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Updated payment and spend permission interfaces to use
bigintinstead of hex strings for value fields in call data structures.How was this tested?
Unit test coverage updated across all affected modules:
charge.test.ts: Updated test expectations to use bigint valuespay.test.ts: Refactored test suite with improved mocking and validationprepareCharge.test.ts: Updated mock data to use bigint valuesprepareSpendCallData.test.ts: Updated all test assertions for bigint valuesprepareRevokeCallData.test.ts: Updated test expectations for bigint valuesHow can reviewers manually test these changes?
Demo/screenshots