-
Notifications
You must be signed in to change notification settings - Fork 14
feat: Add cloud storage integration with S3 upload/download and snapshot management #107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🟡 Heimdall Review Status
|
e8ad7c4
to
b7a3663
Compare
e11628b
to
715d03f
Compare
92cab4c
to
c758c68
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks awesome! I love all the new UI elements and how you integrated machine type/etc. Is there a way to make this agnostic to S3?
It looks like we're tying the report generation to S3 now, but users may want to use other cloud storage, or something like Github Actions.
- export: downloads and uploads to s3 - can be done using
aws s3 cp
outside of the benchmark tool - serving from s3: this is just a static file server pulling from S3 - could just use an existing solution to serve static files
One philosophy I think we should adopt here is: do one thing and do it well. I think adding S3 download/upload/serving is nice to have, but I'm not sure it makes sense to include in the external repo that other teams may use who may not use S3.
The point of serving data from static files instead of a backend is that it makes deployment super simple. All of this work seems compatible with the static file interface, so adding S3 seems slightly unnecessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have all POW to contract this work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some more comments, but looks good overall!
I have a few suggestions:
- remove AWS integration from this repo - this should probably just be in our internal repo
- remove report backend from this repo - also can be in our internal repo - externally, people can use a static file system
Other than removing AWS dependency, I think the chain copy behavior is a little bit confusing. For ZFS, would I reuse_existing
or chain_copy
?
40bd8c3
to
138892f
Compare
138892f
to
a3364ad
Compare
🚀 Core Features Added:
AWS S3 Cloud Storage Integration
export-to-cloud
command to upload entire output directories to S3--enable-s3
flagImport/Export System for Benchmark Results
import-runs
command to import benchmark results from local files or remote URLsEnhanced Snapshot Management System
Machine Information Collection
Report Backend API Improvements
Frontend Enhancements
🔧 Technical Improvements: