Skip to content

Conversation

stevieraykatz
Copy link
Contributor

Also adds a no-op disbursement14 to eat the nonce that was used in the ownership transfer of #401

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Sep 10, 2025

✅ Heimdall Review Status

Requirement Status More Info
Reviews 2/2
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 2
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 2
2
1 if commit is unverified 0
Sum 2

Copy link

❌ Upgrade Structure Validation Failed

The validation check found issues with your upgrade folder structure. Please ensure:

  1. All upgrade folders have a validations/ subdirectory
  2. Each validations/ folder contains at least one config file:
    • base-nested.json (for Coinbase validation)
    • base-sc.json (for Base SC validation)
    • op.json (for OP validation)
  3. All JSON files are valid and follow the correct schema

Please check the CI logs above for specific error details and fix the issues before merging.

📖 See the validation documentation for more details.

To disable the validation check please add a validation.yml file to your upgrade folder with 'disabled': true

Copy link

❌ Upgrade Structure Validation Failed

The validation check found issues with your upgrade folder structure. Please ensure:

  1. All upgrade folders have a validations/ subdirectory
  2. Each validations/ folder contains at least one config file:
    • base-nested.json (for Coinbase validation)
    • base-sc.json (for Base SC validation)
    • op.json (for OP validation)
  3. All JSON files are valid and follow the correct schema

Please check the CI logs above for specific error details and fix the issues before merging.

📖 See the validation documentation for more details.

To disable the validation check please add a validation.yml file to your upgrade folder with 'disabled': true

@amiecorso amiecorso self-requested a review September 10, 2025 21:59
@stevieraykatz stevieraykatz merged commit 9698ae2 into main Sep 11, 2025
5 of 6 checks passed
@stevieraykatz stevieraykatz deleted the send-basecamp-name branch September 11, 2025 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants