Expand secret environment variables in accessory files #1601
+22
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thank's @aliismayilov! Happy to merge this one since #1724 now allows you to lock down permissions on those files. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When accessory file ends with
.erb, it's possible to interpolate environment variables in it. Currently, only clear environment variables are expanded. Not sure if it was a deliberate choice.This PR includes all env variables (including the aliased ones) in the ERB template processing.
Background: I was trying to run PgBouncer (a PostgreSQL connection pooler) as an accessory, which required the database connection string to be present in its configuration file. I managed to work around this by generating the final config file through a Docker entrypoint script. However, if this PR is accepted, the setup would become much simpler.