-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Add preview images to the themes menu #3444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Oh yes, would love to get previews! Maybe @abenz1267 has a way for us to turn off icons but keep the image previews? |
|
You can create a new item layout file and remove the icons in there. Walker also allows creating actual grid layouts in git... If you prefer that over the preview pane. |
|
Actual grid would be pretty sweet if we can get the aesthetics right with spacing/padding/text centering! Especially if there's four-way navigation with the arrows? Does the grid also still have filtering via input? |
|
You'd need to create a |
|
Would love that! @tahayvr please do feel free to explore this. What I've noticed on other grids is that it's crucial that the previews are the same size and the text is properly aligned. Otherwise it can look messy quickly. Also curious to see whether our stock preview.png's work well if we have a 3x4 grid. Think we'll just have to feel it out. |
|
Performance might be an issue. Ofc with the preview pane you only load 1 image at a time and not... all. So you might wanna create actual fitting thumbnails. |
|
i mean: just removing |
|
Happy just to start with the preview pane version minus the icon. Then we could experiment with full grid in round 2. |
|
We'll need theme names to be human readable (no snake case, capitalization). And we'll need even spacing from the last character to the preview as there is from the first character to the left border and the preview to the right border. But otherwise this looks very promising! |
|
I think that's fine, actually. We should put out some guidelines for how to look the best with the extra themes. But yeah, this now looks fantastic 🤘 |
|
One thing we should do is fix all the current preview.pngs. They're not all the same size/layout. We should just have the same applications open on all the themes and then take new screenshots. Also, I fixed so the width is constant, but the preview is currently moving when I filter down the list. Would be great if we could fix that offset somehow. |
|
I think the wide ones (16:9 ratio like Osaka Jade's preview) look better. I'll update the files with consistent size and layout. |
|
I just did a new set. Will add. |
|
Only thing missing is to keep the menu stable when you're filtering. Right now there's some zooming and moving going on. |
|
Also, need to have a placeholder image for themes that do not ship with a preview.png, like monochrome: https://github.com/Swarnim114/omarchy-monochrome-theme |
|
Good idea 👍 |
But we still do have movement when filtering the menu down to a shorter-than-longest name. Should try to stabilize that.
|
I updated the script to use first bg image as fallback for preview files. |
|
Two small nits:
Not sure we have control over #2, though? Maybe that's hardcoded? Is there a way to control the width of the preview image @abenz1267? |
|
not at the moment |
|
I fixed the height thing. Here's the slightly odd zoom issue. When/if Walker gets a way to control that we can incorporate: screenrecording-2025-11-18_17-16-02.mp4 |
|
@tahayvr I don't see the background fallback working? Could you try with the monochrome theme: https://github.com/Swarnim114/omarchy-monochrome-theme.git |
|
@tahayvr The padding around the preview image also looks off. Slimmer sides than top:
|
Did you restart walker?
|
I removed '@background' from '.preview' to get rid of that weird dark frame around the image. Also think the padding change was useless since we can't keep the image position fixed when images have different ratios and sizes. |









This PR adds a new script for elephant to display theme preview images in the menu.
Still trying to figure out how to disable the icons so they don't show up. Sharing this as a draft for feedback/help.