Skip to content

Release/downloader v1.1 #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: release/downloader-v1.0
Choose a base branch
from
Open

Release/downloader v1.1 #2

wants to merge 8 commits into from

Conversation

sujitp81
Copy link
Contributor

No description provided.

adamnation and others added 8 commits March 11, 2014 17:00
@adamnation
Merge branch 'release/downloader-v1.0'
eb3fda5
@adamnation
merge release/downloader-v1 into master. made some methods public so …
0318e18 
…unit tests can run
@sujitp81
Sujit: Removed Sigining and "XAMARIN" constant which would've forced …
43e44ba 
…TV to trust all SSL cert
@adamnation
Revert "Sujit: Removed Sigining and "XAMARIN" constant which would've…
8a29a83 
… forced TV to trust all SSL cert"

revert sujit's accidental check in

This reverts commit 43e44ba.
@sujitp81
Sujit: BuildFix: Removed sigining from TV, link to the snk file insid…
db0364e 
…e the SpaceElevator project, and XAMARIN from build definitions
@adamnation
Merge pull request #1 from basespace/bugfix/remove-downloader-artefacts
4c9adff 
Sujit: BuildFix: Removed sigining from TV, link to the snk file inside t...
@sujitp81
Sujit: Modified csproj for strongnaming
c14388c
@sujitp81
Sujit: Added XamarinMacRelease and XamarinMacDebug configuration cont…
82fae8b 
…aining the build-time-constant "XAMARIN" for XamarinMac sln of SpaceElevator/Downloader to trust all SSL cert
@greghroberts
Copy link
Contributor

@sujitp81 why change of internal to public on all of these?

@adamnation
Copy link
Contributor

that was me, so the unit tests could run. I didn't notice there was some project property that @sujitp81 turned off at the time. might want to revert that change, and turn back on the project property that allows the unit tests to run

@greghroberts
Copy link
Contributor

@adamnation yes, we shouldn't be making things public just for unit tests. Leverage the "InternalsVisibleTo" assembly info property.

@sujitp81
Copy link
Contributor Author

Just noticed this pull req.
If we want to strongname binaries, it cannot have "InternalsVisibleTo" property. Strongnaming is required only for SpaceElevator. So I had disabled the unit-tests and "InternalsVisibleTo" for the SDK branch for Downloader. So, maybe we should not be merging the Downloader's SDK branch to master..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sujitp81 @greghroberts @adamnation