Skip to content

Add parameter validation #577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 3, 2025
Merged

Add parameter validation #577

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a344b8a
Add paramter validation
spline2hg Jun 23, 2025
8f70b2d
fix: pre-commit
spline2hg Jun 24, 2025
0a3884f
fix: xi
spline2hg Jun 26, 2025
1169da5
fix: docstrings
spline2hg Jun 27, 2025
44b57e8
add tests
spline2hg Jun 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions bayes_opt/acquisition.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -452,6 +452,12 @@ def __init__(
if kappa < 0:
error_msg = "kappa must be greater than or equal to 0."
raise ValueError(error_msg)
if exploration_decay is not None and not (0 < exploration_decay <= 1):
error_msg = "exploration_decay must be greater than 0 and less than or equal to 1."
raise ValueError(error_msg)
if exploration_decay_delay is not None and (not isinstance(exploration_decay_delay, int) or exploration_decay_delay < 0):
error_msg = "exploration_decay_delay must be an integer greater than or equal to 0."
raise ValueError(error_msg)

super().__init__(random_state=random_state)
self.kappa = kappa
Expand Down Expand Up @@ -604,6 +610,16 @@ def __init__(
exploration_decay_delay: int | None = None,
random_state: int | RandomState | None = None,
) -> None:
if xi <= 0:
error_msg = "xi must be greater than 0."
raise ValueError(error_msg)
if exploration_decay is not None and not (0 < exploration_decay <= 1):
error_msg = "exploration_decay must be greater than 0 and less than or equal to 1."
raise ValueError(error_msg)
if exploration_decay_delay is not None and (not isinstance(exploration_decay_delay, int) or exploration_decay_delay < 0):
error_msg = "exploration_decay_delay must be an integer greater than or equal to 0."
raise ValueError(error_msg)

super().__init__(random_state=random_state)
self.xi = xi
self.exploration_decay = exploration_decay
Expand Down Expand Up @@ -778,6 +794,16 @@ def __init__(
exploration_decay_delay: int | None = None,
random_state: int | RandomState | None = None,
) -> None:
if xi <= 0:
error_msg = "xi must be greater than 0."
raise ValueError(error_msg)
if exploration_decay is not None and not (0 < exploration_decay <= 1):
error_msg = "exploration_decay must be greater than 0 and less than or equal to 1."
raise ValueError(error_msg)
if exploration_decay_delay is not None and (not isinstance(exploration_decay_delay, int) or exploration_decay_delay < 0):
error_msg = "exploration_decay_delay must be an integer greater than or equal to 0."
raise ValueError(error_msg)

super().__init__(random_state=random_state)
self.xi = xi
self.exploration_decay = exploration_decay
Expand Down
Loading