Skip to content

remove useless override #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

remove useless override #124

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Controller/Adminhtml/Config/Sftp/TestConnection.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
use Magento\Store\Api\Data\StoreInterface;
use Magento\Store\Model\StoreManagerInterface;
use Magento\Store\Model\ScopeInterface;
use Magento\Framework\Filesystem\Io\Sftp;

/**
* Class TestConnection
Expand All @@ -31,7 +32,7 @@ class TestConnection extends Action
*/
public function __construct(
Context $context,
\Bazaarvoice\Connector\Model\Filesystem\Io\Sftp $sftp,
Sftp $sftp,
ConfigProviderInterface $configProvider,
StoreInterface $store,
StoreManagerInterface $storeManager,
Expand Down
2 changes: 1 addition & 1 deletion Model/Feed/Feed.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@

use Bazaarvoice\Connector\Api\ConfigProviderInterface;
use Bazaarvoice\Connector\Api\StringFormatterInterface;
use Bazaarvoice\Connector\Model\Filesystem\Io\Sftp;
use Magento\Framework\Filesystem\Io\Sftp;
use Bazaarvoice\Connector\Model\Source\Scope;
use Exception;
use Magento\Store\Model\Group;
Expand Down
35 changes: 0 additions & 35 deletions Model/Filesystem/Io/Sftp.php
View file
Open in desktop

This file was deleted.

4 changes: 0 additions & 4 deletions etc/di.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,10 +44,6 @@
</type>
<preference for="Magento\ReviewStaging\Ui\DataProvider\Product\Form\Modifier\Review" type="Bazaarvoice\Connector\Ui\ReviewStaging\Review"/>


<!-- sftp -->
<preference for="Magento\Framework\Filesystem\Io\Sftp" type="Bazaarvoice\Connector\Model\Filesystem\Io\Sftp" />

<!-- Admin Grid -->
<type name="Magento\Framework\View\Element\UiComponent\DataProvider\CollectionFactory">
<arguments>
Expand Down