Skip to content

Conversation

@comius
Copy link
Contributor

@comius comius commented Oct 24, 2025

All uses need to be through rules_cc, because C++ will be removed from Bazel.

All uses need to be through rules_cc, because C++ will be removed from
Bazel.
@comius comius force-pushed the remove-native-cc-uses branch from b633448 to 0ad5159 Compare October 24, 2025 12:11
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @comius, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request removes the cc_helper.bzl file. This change is motivated by the upcoming removal of native C++ support in Bazel, necessitating the use of rules_cc for all C++ related functionalities.

Highlights

  • Removal of cc_helper.bzl: The file python/private/cc_helper.bzl has been removed.
  • Reason for Removal: The removal is part of an effort to ensure all C++ usage goes through rules_cc, as native C++ support will be removed from Bazel.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the python/private/cc_helper.bzl file, which was an adapter for accessing Bazel's internal native C++ implementation. This change aligns with the stated goal of migrating to rules_cc as native C++ support is being removed from Bazel. The change is a simple and clean file deletion. Based on the provided context, the file appears to be unused, so its removal is appropriate.

@aignas
Copy link
Collaborator

aignas commented Oct 26, 2025

This is related to #3367

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants