[bugfix] Reference os variable instead of os function #630
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
on toolchain/internal/common.bzl:121, we referenced the `os` function instead of the local `_os` variable, which made my local build throw stacktraces on toolchain_llvm v1.5.0 (was ok in v1.4.0). I no longer have stacktraces with this fix locally present..
ha1dfo
requested review from
dzbarsky,
fmeum,
helly25,
jsharpe and
rrbutani
as code owners
fmeum
approved these changes
Dec 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
on toolchain/internal/common.bzl:121, we referenced the
osfunction instead of the local_osvariable, which made my local build throw stacktraces on toolchain_llvm v1.5.0 (was ok in v1.4.0).I no longer have stacktraces with this fix locally present..