Skip to content

Allow passing keystore password other than android #426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
snazhmudinov wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Allow passing keystore password other than android #426

snazhmudinov wants to merge 1 commit into from

Conversation

@snazhmudinov
Copy link
Contributor

@snazhmudinov snazhmudinov commented Dec 2, 2025

@snazhmudinov
Copy link
Contributor Author

snazhmudinov commented Dec 2, 2025

@ahumesky @ted-xie can you check this one?

snazhmudinov
snazhmudinov commented Dec 2, 2025
View reviewed changes
rules/android_binary/attrs.bzl
),
keystore_signing_password = attr.string(
doc = """
The password for the KeyStore that contains the signer's key and certificate.
Copy link
Contributor Author

@snazhmudinov snazhmudinov Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

taken from official Android documentation: https://developer.android.com/tools/apksigner?hl=en#options-sign-key-cert

@snazhmudinov
Copy link
Contributor Author

snazhmudinov commented Dec 2, 2025

cc: @meisterT

@ahumesky
Copy link
Collaborator

ahumesky commented Dec 2, 2025

I'm not sure that this is good idea because it could appear to encourage checking passwords into source control since this goes into a build file. In general with bazel (and internally with blaze) signing outputs is handled outside of the build system (besides the debug key in the case of android).

@snazhmudinov
Copy link
Contributor Author

snazhmudinov commented Dec 3, 2025

I'm not sure that this is good idea because it could appear to encourage checking passwords into source control since this goes into a build file. In general with bazel (and internally with blaze) signing outputs is handled outside of the build system (besides the debug key in the case of android).

Yes, I was having in mind the password for the debug keystore. If that's okay, where would the logic go?

@snazhmudinov snazhmudinov force-pushed the sherozn/make-keystore-password-configurable branch from 1b7f9c1 to 91fecd5 Compare December 3, 2025 06:23
@snazhmudinov
Copy link
Contributor Author

snazhmudinov commented Dec 10, 2025

@ahumesky any thoughts on the last comment?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@snazhmudinov @ahumesky