Add experimental Build Tools API (BTAPI) for compilation #1325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikkerber
force-pushed
the
ek/add-experimental-build-tools-api
branch
4 times, most recently
from
2441efe to
57e6805
Compare
|
The integration tests I believe are hung up on not having any reference to the Maven artifacts in Would look to the maintainers for guidance here. |
erikkerber
requested review from
ahumesky,
cgruber,
restingbull,
Bencodes and
nkoroste
as code owners
erikkerber
force-pushed
the
ek/add-experimental-build-tools-api
branch
4 times, most recently
from
87c1775 to
e644ea7
Compare
restingbull
reviewed
Jun 5, 2025
There was a problem hiding this comment.
Let's add the [basic jvm smoke test].(https://github.com/bazelbuild/rules_kotlin/blob/master/src/test/kotlin/io/bazel/kotlin/builder/tasks/jvm/KotlinBuilderJvmBasicTest.java)
And an iteration to the integration tests to include a run with the flag true and false.
Just to keep us honest.
src/main/kotlin/io/bazel/kotlin/compiler/BuildToolsAPICompiler.kt
Outdated
Show resolved
Hide resolved
restingbull
force-pushed
the
ek/add-experimental-build-tools-api
branch
from
7351778 to
e2b170c
Compare
Bencodes
approved these changes
Jun 6, 2025
erikkerber
added a commit
to tinyspeck/rules_kotlin
that referenced
this pull request
Jun 16, 2025
…1325) * Add experimental Build Tools API (BTAPI) for compilation * Provision build tools API with http_archive over Maven * Fixup maven_install * Add build tools api to the integration tests --------- Co-authored-by: Corbin McNeely-Smith <[email protected]>
oliviernotteghem
pushed a commit
to uber-common/rules_kotlin
that referenced
this pull request
Jun 18, 2025
…1325) * Add experimental Build Tools API (BTAPI) for compilation * Provision build tools API with http_archive over Maven * Fixup maven_install * Add build tools api to the integration tests --------- Co-authored-by: Corbin McNeely-Smith <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables opting in to building with the Build Tools API (BTAPI). A simpler subset of #1316
The default configuration for
CompilationServicelands in a similar invocation ofK2JVMCompilerthat the currentBazelK2JVMCompilerdoes, so this should very much be a drop-in replacement.This approach still pins the BTAPI to
2.1.20, which may result in issues when using a different version of Kotlin. If the BTAPI is never shipped along Kotlin itself and that is a problem, then we'll have to somehow tie the version in Maven to the Kotlin version.BTAPI References: