Skip to content

Conversation

sardok
Copy link
Contributor

@sardok sardok commented Jun 27, 2025

This PR introduces CARGO_BAZEL_TIMEOUT env variable to set timeout value for cargo-bazel invocation.

Copy link

google-cla bot commented Jun 27, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@sardok sardok force-pushed the cargo-bazel-timeout branch from 3114fa6 to 89e8296 Compare June 27, 2025 13:13
Copy link
Collaborator

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Please can you add the env var to

CRATES_REPOSITORY_ENVIRON = GENERATOR_ENV_VARS + REPIN_ENV_VARS + [
as well to make sure we'll invalidate and re-run the repository rules if the env var changes?

Thanks!

@sardok
Copy link
Contributor Author

sardok commented Jul 28, 2025

Thanks @illicitonion for the review. I added the change you asked. Also updated the rule & extension docs about it (although i'm not sure if it is right thing to do because CARGO_BAZEL_DEBUG is missing there, maybe some env vars shouldn't be documented?).

Copy link
Collaborator

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks!

@illicitonion illicitonion enabled auto-merge August 2, 2025 20:59
@illicitonion illicitonion added this pull request to the merge queue Aug 2, 2025
Merged via the queue into bazelbuild:main with commit a44ac6e Aug 2, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants